Skip to content

Add Area Multiple Selector option#12138

Merged
zsarnett merged 2 commits intodevfrom
Areas-Selector
Mar 28, 2022
Merged

Add Area Multiple Selector option#12138
zsarnett merged 2 commits intodevfrom
Areas-Selector

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

CleanShot 2022-03-28 at 08 26 03

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Mar 28, 2022
Comment on lines +137 to +143
if (!toAdd) {
return;
}
(ev.currentTarget as any).value = "";
if (!toAdd) {
return;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double?

bramkragten
bramkragten previously approved these changes Mar 28, 2022
@zsarnett zsarnett merged commit b080bca into dev Mar 28, 2022
@zsarnett zsarnett deleted the Areas-Selector branch March 28, 2022 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants