Allow binary sensor device class updates#12124
Merged
Conversation
balloob
reviewed
Mar 25, 2022
balloob
reviewed
Mar 25, 2022
balloob
reviewed
Mar 28, 2022
| ], | ||
| ], | ||
| binary_sensor: [ | ||
| ["connectivity", "lock", "update"], // Other |
Member
There was a problem hiding this comment.
connectivity and update
I don't see how this ever can be miscategorized and the user needs to edit it… do we really need to cover ALL binary sensor device classes ?
Contributor
Author
There was a problem hiding this comment.
Update I can see
But I could see Connectivity being needed?
Member
There was a problem hiding this comment.
I guess if you want to change connectivity to be problem?
Contributor
Author
There was a problem hiding this comment.
I took it out. I guess lets see if it comes up
balloob
reviewed
Mar 28, 2022
| return; | ||
| } | ||
|
|
||
| this._error = undefined; |
Member
There was a problem hiding this comment.
All these things will cause a new re-render. That means the changes need to be made in willUpdate.
balloob
previously approved these changes
Mar 28, 2022
balloob
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Allows choosing between all device classes in the binary sensor settings
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: