Fix issue where theme select does not appear when user's theme is deleted#12104
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Mar 24, 2022
Merged
Conversation
Contributor
Author
|
To recreate issue/test the fix:
|
bramkragten
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes #11701 where the theme selection is missing.
This is because the code is trying to check if the theme supports light/dark mode, but this won't work if the theme has been deleted.
This is a quick fix, and means the selector appears again. Perhaps there could be a better fix, where we reset the user's theme if it's one that has been deleted?
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: