Conversation
zsarnett
commented
Mar 22, 2022
|
|
||
| @property({ type: Boolean }) public required = true; | ||
|
|
||
| protected firstUpdated(changedProps: PropertyValues): void { |
Contributor
Author
There was a problem hiding this comment.
I am thinking now. Should this be in will update?
Member
There was a problem hiding this comment.
ha-form applies the default value if nothing is set. It's weird that we can get here and then set the duration.
I think instead in the rendering we should just do const value = this.value || "0:00:00"
Contributor
Author
There was a problem hiding this comment.
We need to send the value to HA form
Contributor
Author
There was a problem hiding this comment.
Ha form doesnt default the value.
Not for selectors
That was my first thought as well
Member
There was a problem hiding this comment.
balloob
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Sets the value via Value Changed event on first updated. This make sure that HA form is aware without changing any lower element functionality
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: