Skip to content

Add support for integration type#12077

Merged
zsarnett merged 4 commits intodevfrom
config-flow-integration-type
Mar 22, 2022
Merged

Add support for integration type#12077
zsarnett merged 4 commits intodevfrom
config-flow-integration-type

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 18, 2022

Breaking change

Proposed change

Allow configuring integrations marked as "helper" from the helpers page.

image

image

To do:

  • Allow deletion

Requires home-assistant/core#68349

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

"follow_device_area": "Follow device area",
"change_device_area": "Change device area"
"change_device_area": "Change device area",
"configure_state": "Configure State"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit Options?

I think the word edit is better than configure for these. State is weird as you aren't changing the state. you could change the options of a select. which doesn't change the state

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more than just a select. It can be a timer, a derivative sensor, a switch_as_x entity, etc.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. So configure state doesn't make sense for everything. The dialog is also called options.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog is called settings:

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog that configure state opens is that called options like it was in your edemo the other day?

Co-authored-by: Zack Barett <zackbarett@hey.com>
@zsarnett zsarnett enabled auto-merge (squash) March 22, 2022 19:45
@zsarnett zsarnett merged commit 73f5580 into dev Mar 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the config-flow-integration-type branch March 22, 2022 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants