Skip to content

Ignore diagnostics not found exceptions#12066

Merged
balloob merged 1 commit intodevfrom
ignore-diagnostic-exception
Mar 17, 2022
Merged

Ignore diagnostics not found exceptions#12066
balloob merged 1 commit intodevfrom
ignore-diagnostic-exception

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 17, 2022

Breaking change

Proposed change

When a config entry didn't support diagnostics an error was raised. This PR makes sure we catch it.

Diff a bit unwieldy due to prettier kicking in after adding types. Recommend to read while ignoring whitespace changes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit ea19740 into dev Mar 17, 2022
@balloob balloob deleted the ignore-diagnostic-exception branch March 17, 2022 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants