Conversation
ludeeus
commented
Mar 16, 2022
zsarnett
reviewed
Mar 16, 2022
zsarnett
reviewed
Mar 16, 2022
zsarnett
reviewed
Mar 16, 2022
zsarnett
previously approved these changes
Mar 16, 2022
Co-authored-by: Zack Barett <zackbarett@hey.com>
ludeeus
added
the
needs design preview
ludeeus
commented
Mar 21, 2022
balloob
reviewed
Mar 22, 2022
balloob
reviewed
Mar 22, 2022
balloob
reviewed
Mar 22, 2022
balloob
reviewed
Mar 22, 2022
balloob
reviewed
Mar 22, 2022
| "ui.dialogs.more_info_control.update.latest_version" | ||
| )} | ||
| </div> | ||
| <div class="value">${this.stateObj.attributes.latest_version}</div> |
Member
There was a problem hiding this comment.
Should we render a placeholder if no latest version available ? Same with current version that can be null according to type.
Member
Author
There was a problem hiding this comment.
Sure!, have a suggestion on what that should be?
localise('state.default.unknown')?
balloob
reviewed
Mar 22, 2022
| this.hass.callService("update", "install", { | ||
| entity_id: this.stateObj!.entity_id, | ||
| backup: this._shouldCreateBackup, | ||
| version: supportsFeature(this.stateObj!, UPDATE_SUPPORT_SPECIFIC_VERSION) |
Member
There was a problem hiding this comment.
If an update entity supports specific version, can we not pass null to pick last version automatically?
Member
Author
There was a problem hiding this comment.
I don't see why we can't, I'll test that out and adjust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
For home-assistant/core#68248
Preview https://62399243fc89eb000a079abd--home-assistant-gallery.netlify.app/#more-info/update
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: