Skip to content

Add Color RGB Selector#12039

Merged
balloob merged 8 commits intodevfrom
color-rgb-selector
Mar 15, 2022
Merged

Add Color RGB Selector#12039
balloob merged 8 commits intodevfrom
color-rgb-selector

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Mar 14, 2022

Breaking change

Proposed change

CleanShot 2022-03-15 at 17 16 22

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Mar 14, 2022
balloob
balloob previously approved these changes Mar 14, 2022
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 14, 2022

Don't forget the docs.

@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 15, 2022

I guess the current design is fine for first iteration but I would prefer if we could encapsulate this in a color button that opens the picker when pressed, like we do theme colors on the profile page.

@zsarnett
Copy link
Copy Markdown
Contributor Author

Should we just use the input type color?

balloob
balloob previously approved these changes Mar 15, 2022
@zsarnett
Copy link
Copy Markdown
Contributor Author

CleanShot 2022-03-15 at 17 16 22

@balloob balloob merged commit 5c53bc4 into dev Mar 15, 2022
@balloob balloob deleted the color-rgb-selector branch March 15, 2022 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants