Skip to content

Use entities-picker in entity selector#11990

Merged
zsarnett merged 1 commit intodevfrom
entities-picker-selector
Mar 9, 2022
Merged

Use entities-picker in entity selector#11990
zsarnett merged 1 commit intodevfrom
entities-picker-selector

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 9, 2022

Breaking change

Proposed change

Earlier today in #11986 I created my own entities picker, this replaces that work with the existing one.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Mar 9, 2022
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for not catching this earlier either

@zsarnett zsarnett merged commit 9f1e9b4 into dev Mar 9, 2022
@zsarnett zsarnett deleted the entities-picker-selector branch March 9, 2022 03:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants