Skip to content

Fix zwave_js set config dropdown default value#11974

Merged
zsarnett merged 4 commits intohome-assistant:devfrom
cgarwood:zwjs_config_select_fix
Mar 10, 2022
Merged

Fix zwave_js set config dropdown default value#11974
zsarnett merged 4 commits intohome-assistant:devfrom
cgarwood:zwjs_config_select_fix

Conversation

@cgarwood
Copy link
Copy Markdown
Member

@cgarwood cgarwood commented Mar 8, 2022

Proposed change

With the switch from paper elements to <ha-select> the default value wasn't working in the Z-Wave JS Node Config panel. From what I could tell, the value was sometimes being parsed as an integer, while the
value of a list-item was being parsed as a string. So we're coercing all the values to a string.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@raman325 raman325 added this to the 2022.3.0 milestone Mar 8, 2022
@kpine
Copy link
Copy Markdown
Contributor

kpine commented Mar 8, 2022

Fixes home-assistant/core#67765.

…ve_js-node-config.ts

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
zsarnett
zsarnett previously approved these changes Mar 9, 2022
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to run prettier

@zsarnett zsarnett merged commit f89b8cf into home-assistant:dev Mar 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants