Fix zwave_js set config dropdown default value#11974
Merged
zsarnett merged 4 commits intohome-assistant:devfrom Mar 10, 2022
Merged
Fix zwave_js set config dropdown default value#11974zsarnett merged 4 commits intohome-assistant:devfrom
zsarnett merged 4 commits intohome-assistant:devfrom
Conversation
Contributor
|
Fixes home-assistant/core#67765. |
balloob
reviewed
Mar 8, 2022
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-node-config.ts
Outdated
Show resolved
Hide resolved
…ve_js-node-config.ts Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
zsarnett
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
With the switch from paper elements to
<ha-select>the default value wasn't working in the Z-Wave JS Node Config panel. From what I could tell, thevaluewas sometimes being parsed as an integer, while thevalueof a list-item was being parsed as a string. So we're coercing all the values to a string.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: