Skip to content

Correct media upload error + add file name#11949

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:upload-error-fix
Mar 7, 2022
Merged

Correct media upload error + add file name#11949
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:upload-error-fix

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Two changes:

  1. Previously the media upload error said "image", which of course is not always correct (I tried to upload audio WAV files). Now we use generically "file".
  2. Since you can upload multiple files at once (at least for media), it is helpful to know which file actually caused the error. Therefore I added the filename in brackets.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier added this to the 2022.3.0 milestone Mar 5, 2022
zsarnett
zsarnett previously approved these changes Mar 6, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten enabled auto-merge (squash) March 7, 2022 11:59
@bramkragten bramkragten merged commit 2e10eb0 into home-assistant:dev Mar 7, 2022
bramkragten added a commit that referenced this pull request Mar 7, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants