Skip to content

Guard setting up config flow for an unsupported domain#11937

Merged
balloob merged 1 commit intodevfrom
guard-config-flow-wrong-domain
Mar 4, 2022
Merged

Guard setting up config flow for an unsupported domain#11937
balloob merged 1 commit intodevfrom
guard-config-flow-wrong-domain

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 4, 2022

Breaking change

Proposed change

@ludeeus figured out why we say error messages with [object Object]. It's reproduced pointing a My link at a domain that doesn't support config flows. It's a rest endpoint and so the thrown error follows a different format than if a WebSocket endpoint fails.

I've added an extra guard to the My link to ensure that we check the config flow exists before we ask the user if they want to set it up.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 0936fd9 into dev Mar 4, 2022
@balloob balloob deleted the guard-config-flow-wrong-domain branch March 4, 2022 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants