Skip to content

test condition#11925

Merged
balloob merged 2 commits intodevfrom
condition-test
Mar 16, 2022
Merged

test condition#11925
balloob merged 2 commits intodevfrom
condition-test

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 4, 2022

Breaking change

Proposed change

Allow testing conditions.

CleanShot.2022-03-03.at.21.39.55.mp4

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 4, 2022

image

Nice!

I do wonder if the color of the button is clear enough though. It feels like it almost provided no feedback on the result (as in it might be confused with the feedback on the click itself, not the click result).

@matthiasdebaat
Copy link
Copy Markdown
Member

We can use the same pattern as we have for Configuration validation:
Valid prototype
Invalid prototype

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 4, 2022

The test button is not about if the condition is valid but if it tests true right now (side effect is validating it or else we can't test it, but most things made via UI will be valid)

@bdr99
Copy link
Copy Markdown
Contributor

bdr99 commented Mar 5, 2022

This is a great feature, but those affected by color blindness might have a hard time distinguishing between those two colors, considering that red-green color blindness is the most common form of color blindness. It might be helpful to add some kind of additional visual feedback, such as a ✅ or ❌ to indicate whether the condition tested true.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 8, 2022

Added icons to the progress button

CleanShot.2022-03-08.at.11.36.24.mp4

@@ -1,8 +1,9 @@
import "@material/mwc-button";
import type { Button } from "@material/mwc-button";
import { mdiAlertOctagram, mdiCheckBold } from "@mdi/js";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the X if we are using the check?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I felt like X could also indicate bad config.

@balloob balloob merged commit ab5df0f into dev Mar 16, 2022
@balloob balloob deleted the condition-test branch March 16, 2022 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants