Skip to content

Show triggered vars on click#11924

Merged
balloob merged 2 commits intodevfrom
triggered-vars
Mar 5, 2022
Merged

Show triggered vars on click#11924
balloob merged 2 commits intodevfrom
triggered-vars

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 4, 2022

Breaking change

Proposed change

Allow clicking on the TRIGGERED bar to show the variables.

CleanShot.2022-03-03.at.21.26.17.mp4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 4, 2022

It is kinda a nice little advanced feature, I guess?

But it's not clear this can be clicked from the UI. Maybe add a small (ℹ) icon after the "TRIGGERED" keyword to make that clear?

@matthiasdebaat
Copy link
Copy Markdown
Member

I would suggest to change the color of the bar on hover. I made an quick prototype to illustrate. The bar is 16px, which is too narrow for an info icon. Other design changes are more drastic for the average user.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 4, 2022

Fading it out to 80% now. Screenshots might not show impactful, but it's clearly noticeable on hover.

image

image

image

image

@balloob balloob merged commit bd20c15 into dev Mar 5, 2022
@balloob balloob deleted the triggered-vars branch March 5, 2022 07:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants