Skip to content

Fix quickbar overlaying, fix click handling#11900

Merged
bramkragten merged 2 commits intodevfrom
quicbar-virtualize-overlap
Mar 2, 2022
Merged

Fix quickbar overlaying, fix click handling#11900
bramkragten merged 2 commits intodevfrom
quicbar-virtualize-overlap

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Mar 2, 2022

Proposed change

Waiting with rendering the list until the dialog is done animating, fix click handling on item text or badge.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten changed the title Add a few button labels (#11885) Fix quickbar overlaying, fix click handling Mar 2, 2022
@bramkragten bramkragten added this to the 2022.3.0 milestone Mar 2, 2022
@bramkragten bramkragten marked this pull request as ready for review March 2, 2022 15:50
@bramkragten bramkragten merged commit add92a5 into dev Mar 2, 2022
@bramkragten bramkragten deleted the quicbar-virtualize-overlap branch March 2, 2022 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants