Skip to content

Stop spinning when opening media in dialog #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Feb 23, 2022
Merged

Stop spinning when opening media in dialog #11800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/components/media-player/dialog-media-manage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
import { animate } from "@lit-labs/motion";
import "@material/mwc-list/mwc-check-list-item";
import "@material/mwc-list/mwc-list-item";
import "@material/mwc-list/mwc-list";
import { repeat } from "lit/directives/repeat";
import "@material/mwc-list/mwc-list-item";
import { mdiClose, mdiDelete } from "@mdi/js";
import { css, CSSResultGroup, html, LitElement, TemplateResult } from "lit";
import { customElement, property, state } from "lit/decorators";
import { repeat } from "lit/directives/repeat";
import { fireEvent } from "../../common/dom/fire_event";
import { computeRTLDirection } from "../../common/util/compute_rtl";
import { haStyleDialog } from "../../resources/styles";
import type { HomeAssistant } from "../../types";
import "../ha-header-bar";
import "../ha-dialog";
import "../ha-svg-icon";
import "../ha-circular-progress";
import "./ha-media-player-browse";
import "./ha-media-upload-button";
import type { MediaManageDialogParams } from "./show-media-manage-dialog";
import {
MediaClassBrowserSettings,
MediaPlayerItem,
Expand All @@ -26,6 +16,16 @@ import {
removeLocalMedia,
} from "../../data/media_source";
import { showConfirmationDialog } from "../../dialogs/generic/show-dialog-box";
import { haStyleDialog } from "../../resources/styles";
import type { HomeAssistant } from "../../types";
import "../ha-circular-progress";
import "../ha-dialog";
import "../ha-header-bar";
import "../ha-svg-icon";
import "../ha-check-list-item";
import "./ha-media-player-browse";
import "./ha-media-upload-button";
import type { MediaManageDialogParams } from "./show-media-manage-dialog";

@customElement("dialog-media-manage")
class DialogMediaManage extends LitElement {
Expand Down Expand Up @@ -180,7 +180,7 @@ class DialogMediaManage extends LitElement {
></ha-svg-icon>
`;
return html`
<mwc-check-list-item
<ha-check-list-item
${animate({
id: item.media_content_id,
skipInitial: true,
Expand All @@ -191,7 +191,7 @@ class DialogMediaManage extends LitElement {
.item=${item}
>
${icon} ${item.title}
</mwc-check-list-item>
</ha-check-list-item>
`;
}
)}
Expand Down
1 change: 1 addition & 0 deletions src/panels/media-browser/ha-panel-media-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ class PanelMediaBrowser extends LitElement {
title: item.title,
can_play: item.can_play,
});
this._player.hideResolvingNewMediaPicked();
}

private _playerPicked(ev) {
Expand Down