Skip to content

Fix State Condition 'For' Data #11782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Feb 22, 2022
Merged

Fix State Condition 'For' Data #11782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565337b
fix for state condition
zsarnett Feb 22, 2022
bfee5ae
update type
zsarnett Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/datetime/create_duration_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import type { ForDict } from "../../data/automation";

export const createDurationData = (
duration: string | number | ForDict | undefined
): HaDurationData => {
): HaDurationData | undefined => {
if (duration === undefined) {
return {};
return undefined;
}
if (typeof duration !== "object") {
if (typeof duration === "string" || isNaN(duration)) {
Expand Down
2 changes: 1 addition & 1 deletion src/panels/config/automation/action/types/ha-automation-action-delay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class HaDelayAction extends LitElement implements ActionElement {

@property() public action!: DelayAction;

@property() public _timeData!: HaDurationData;
@property() public _timeData?: HaDurationData;

public static get defaultConfig() {
return { delay: "" };
Expand Down
2 changes: 1 addition & 1 deletion src/panels/config/automation/condition/types/ha-automation-condition-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class HaStateCondition extends LitElement implements ConditionElement {

protected render() {
const trgFor = createDurationData(this.condition.for);
const data = { ...this.condition, ...{ for: trgFor } };
const data = { ...this.condition, for: trgFor };
const schema = this._schema(this.condition.entity_id);

return html`
Expand Down