Convert Automation Actions to mwc/ha-form + other automation items#11753
Merged
bramkragten merged 2 commits intodevfrom Feb 21, 2022
Merged
Convert Automation Actions to mwc/ha-form + other automation items#11753bramkragten merged 2 commits intodevfrom
bramkragten merged 2 commits intodevfrom
Conversation
zsarnett
added
the
needs design preview
bramkragten
reviewed
Feb 21, 2022
| .value=${event} | ||
| @value-changed=${this._eventChanged} | ||
| ></paper-input> | ||
| @change=${this._eventChanged} |
Member
There was a problem hiding this comment.
Is change enough, or should it be input?
bramkragten
reviewed
Feb 21, 2022
| )} | ||
| name="count" | ||
| .value=${(action as CountRepeat).count || "0"} | ||
| @hange=${this._countChanged} |
bramkragten
reviewed
Feb 21, 2022
Comment on lines
+55
to
+56
| ev.stopPropagation(); | ||
| fireEvent(this, "value-changed", { value: ev.detail.value }); |
Member
There was a problem hiding this comment.
Do we have to re-emit this? Or can we remove the handler all together?
bramkragten
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Move Actions from paper to MWC or ha-form
catch a few imports and other automation fixes for paper conversion
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: