Skip to content

Change icons for cover with device_class curtain#11752

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
pascalwinters:cover_icon
Feb 22, 2022
Merged

Change icons for cover with device_class curtain#11752
bramkragten merged 4 commits intohome-assistant:devfrom
pascalwinters:cover_icon

Conversation

@pascalwinters
Copy link
Copy Markdown
Contributor

@pascalwinters pascalwinters commented Feb 21, 2022

Breaking change

Proposed change

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Copy Markdown
Member

I'm not sure if this makes it any clearer. I think the horizontal arrows like used for gate are better suited.

@pascalwinters
Copy link
Copy Markdown
Contributor Author

I'm not sure if this makes it any clearer. I think the horizontal arrows like used for gate are better suited.

I understand your remark, but this one is more curtain specific. So it feels more accurate. And it's correlates with the status icon.
The only 'problem', it doesn't look like an action.

@bramkragten
Copy link
Copy Markdown
Member

The only 'problem', it doesn't look like an action.

Yeah, and that's a pretty big problem I would say

@pascalwinters
Copy link
Copy Markdown
Contributor Author

pascalwinters commented Feb 21, 2022

horizontal arrows like used for gate are better suited.

Updated the PR

pascalwinters and others added 2 commits February 21, 2022 21:48
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 940f5c0 into home-assistant:dev Feb 22, 2022
@pascalwinters pascalwinters deleted the cover_icon branch February 22, 2022 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Curtain commands shown as cover

3 participants