Skip to content

Show when media is being loaded#11750

Merged
bramkragten merged 3 commits intodevfrom
media-loaded
Feb 21, 2022
Merged

Show when media is being loaded#11750
bramkragten merged 3 commits intodevfrom
media-loaded

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 21, 2022

Breaking change

Proposed change

Improve experience when media is being loaded.

  • Browser player: Show spinner until media resolves. Then show name + album art while buffering
  • Media player: Show spinner until first state change.
CleanShot.2022-02-20.at.20.40.17.mp4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob changed the title Show when media is loaded Show when media is being loaded Feb 21, 2022
@bramkragten bramkragten merged commit 28cd9b6 into dev Feb 21, 2022
@bramkragten bramkragten deleted the media-loaded branch February 21, 2022 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants