Skip to content

Handle inifinity media duration#11749

Merged
zsarnett merged 1 commit intodevfrom
handle-infinity-media-duration
Feb 21, 2022
Merged

Handle inifinity media duration#11749
zsarnett merged 1 commit intodevfrom
handle-infinity-media-duration

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 21, 2022

Breaking change

Proposed change

media duration set to Infinity would crash compute media time. Now it's handled and it will hide the progress bar completely.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett enabled auto-merge (squash) February 21, 2022 04:02
@zsarnett zsarnett merged commit 9b4c6ee into dev Feb 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the handle-infinity-media-duration branch February 21, 2022 04:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants