Automation Conditions to conversion to ha-form or mwc#11727
Merged
Conversation
zsarnett
commented
Feb 18, 2022
src/panels/config/automation/condition/ha-automation-condition-row.ts
Outdated
Show resolved
Hide resolved
balloob
added
the
needs design preview
balloob
reviewed
Feb 18, 2022
| { name: "entity_id", selector: { entity: {} } }, | ||
| { | ||
| name: "attribute", | ||
| selector: { attribute: { entity_id: entityId } }, |
Member
There was a problem hiding this comment.
One day I hope we can make ha-form fields "context aware", for example, we would tell this selector to use the entity from entity_id data field automatically.
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-state.ts
Outdated
Show resolved
Hide resolved
balloob
previously approved these changes
Feb 18, 2022
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Looks great. Just the required boolean need updating.
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-sun.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-time.ts
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-zone.ts
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-device.ts
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-zone.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-time.ts
Show resolved
Hide resolved
balloob
reviewed
Feb 18, 2022
src/panels/config/automation/condition/types/ha-automation-condition-template.ts
Show resolved
Hide resolved
balloob
previously approved these changes
Feb 18, 2022
balloob
previously approved these changes
Feb 18, 2022
balloob
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Automation Conditions to conversion to ha-form or mwc
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: