Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial focus for supervisor dialogs #11710

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Set initial focus for supervisor dialogs #11710

merged 8 commits into from
Feb 21, 2022

Conversation

steverep
Copy link
Member

Proposed change

Dialog Module Initial Focus Notes
dialog-hassio-backup-upload Close button
dialog-hassio-backup First radio or checkbox
dialog-hassio-create-backup Name field
dialog-hassio-datadisk Combobox or cancel button
dialog-hassio-hardware Search field
dialog-hassio-markdown ha-markdown I don't know how to invoke this one to test. It needs a focus method.
dialog-hassio-network First tab or radio
dialog-hassio-registries Add button or form when adding Focus on ha-form doesn't transfer. I'll fix that in separate PR.
dialog-hassio-repositories Add URL field

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

bramkragten
bramkragten previously approved these changes Feb 21, 2022
@bramkragten bramkragten merged commit 2281f5b into home-assistant:dev Feb 21, 2022
@steverep steverep deleted the supervisor-dialog-focus branch February 21, 2022 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
@steverep steverep linked an issue Aug 13, 2022 that may be closed by this pull request
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal dialogs need keyboard focus management
4 participants