Skip to content

Fix mwc-select in lovelace editors#11708

Merged
bramkragten merged 2 commits intodevfrom
fix-lovelace-editors-mwc-select
Feb 17, 2022
Merged

Fix mwc-select in lovelace editors#11708
bramkragten merged 2 commits intodevfrom
fix-lovelace-editors-mwc-select

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

);
}
} else {
this._guiSupported = false;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a fix for header and footer editors. these were allowing switch back and forth between code editor and nothing when using buttons

</div>
<mwc-select
label="Secondary Info"
.selected=${this._config.secondary_info || "none"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be value

@bramkragten bramkragten merged commit f923228 into dev Feb 17, 2022
@bramkragten bramkragten deleted the fix-lovelace-editors-mwc-select branch February 17, 2022 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants