Convert scene action to service call#11705
Merged
bramkragten merged 4 commits intodevfrom Feb 16, 2022
Merged
Conversation
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
|
|
||
| const getType = (action: Action | undefined) => | ||
| action ? OPTIONS.find((option) => option in action) : undefined; | ||
| const getType = (action: Action | undefined) => { |
Member
There was a problem hiding this comment.
Why can't we re-use getActionType ?
Member
Author
There was a problem hiding this comment.
Because we would have to change all the element names 😅 but yes, I do want to do that, found it a bit late though
balloob
reviewed
Feb 16, 2022
balloob
previously approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Not default to specific scene action anymore, but use a service call.
Needs: home-assistant/core#66672
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: