Add signed add-on capability and adjust max rating#11703
Merged
bramkragten merged 4 commits intodevfrom Feb 17, 2022
Merged
Conversation
ludeeus
commented
Feb 16, 2022
12 tasks
bramkragten
previously approved these changes
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
| green: [5, 6].includes(Number(this.addon.rating)), | ||
| yellow: [3, 4].includes(Number(this.addon.rating)), | ||
| green: [6, 7, 8].includes(Number(this.addon.rating)), | ||
| yellow: [3, 4, 5].includes(Number(this.addon.rating)), |
Member
There was a problem hiding this comment.
This yellow could be a bit darker. It's hard to read with white text.
Member
Author
There was a problem hiding this comment.
It's using this
frontend/src/resources/ha-style.ts
Lines 53 to 58 in 3a664d4
balloob
reviewed
Feb 16, 2022
balloob
previously approved these changes
Feb 17, 2022
bramkragten
approved these changes
Feb 17, 2022
bramkragten
deleted the
Add-signed-add-on-capability-and-adjust-max-rating
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
home-assistant/supervisor#3450 (comment)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: