Merged
Conversation
zsarnett
reviewed
Feb 16, 2022
zsarnett
reviewed
Feb 16, 2022
zsarnett
reviewed
Feb 16, 2022
zsarnett
reviewed
Feb 16, 2022
src/panels/config/automation/action/types/ha-automation-action-media_content_id.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
Co-authored-by: Zack Barett <zackbarett@hey.com>
…-media_content_id.ts Co-authored-by: Zack Barett <zackbarett@hey.com>
Co-authored-by: Zack Barett <zackbarett@hey.com>
Co-authored-by: Zack Barett <zackbarett@hey.com>
bramkragten
force-pushed
the
play-media-action
branch
from
27a1a03 to
d783212
Compare
zsarnett
previously approved these changes
Feb 16, 2022
balloob
added
the
needs design preview
balloob
reviewed
Feb 16, 2022
| selector: { select: { options: ["Option 1", "Option 2"] } }, | ||
| }, | ||
| icon: { name: "Icon", selector: { icon: {} } }, | ||
| media: { name: "Media", selector: { media: {} } }, |
Member
There was a problem hiding this comment.
Can we also add it to the ha-form gallery page. It has a form with all selectors.
Member
There was a problem hiding this comment.
Also, we have automation/selectors.ts too. We have 2 design pages for selectors? 🤣
https://620d65c9f5140e8acf3cf643--home-assistant-gallery.netlify.app/#components/ha-selector
Changing between browse and manual logs a JS error.
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 16, 2022
balloob
reviewed
Feb 17, 2022
balloob
reviewed
Feb 17, 2022
Comment on lines
+166
to
+167
| media_class?: string; | ||
| children_media_class?: string | null; |
Member
There was a problem hiding this comment.
Can we collapse this into a single value to be used?
balloob
previously approved these changes
Feb 17, 2022
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
balloob
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add play media action + media selector
Needs: home-assistant/core#66663Needs: home-assistant/core#66672
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: