Improve stripPrefixFromEntityName to handle colon and space separator#11691
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Feb 15, 2022
bdr99:strip-prefix-colon
Merged
Improve stripPrefixFromEntityName to handle colon and space separator#11691bramkragten merged 1 commit intohome-assistant:devfrom bdr99:strip-prefix-colon
stripPrefixFromEntityName to handle colon and space separator#11691bramkragten merged 1 commit intohome-assistant:devfrom
bdr99:strip-prefix-colon
Conversation
bramkragten
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I noticed that the Z-Wave JS integration (and possibly others) uses a colon and a space to separate device names from entity names. This causes the
stripPrefixFromEntityNamelogic to fail because it is expecting just a space. This has the undesired effect of the full entity names being shown on the device page:This PR expands
stripPrefixFromEntityNameto strip the prefix regardless of whether it is separated by a space, or a colon and a space. This improves the UX by shortening the displayed entity names:Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: