Conversation
Member
|
Really nice! When uploading, can we make the icon into an animated spinner? |
Member
Author
|
done. CleanShot.2022-02-14.at.10.54.29.mp4 |
bramkragten
reviewed
Feb 14, 2022
| const files = input.files!; | ||
| const target = this._currentItem!.media_content_id!; | ||
|
|
||
| try { |
Member
There was a problem hiding this comment.
What will this try catch, as the try inside the loop will catch everything?
Member
Author
There was a problem hiding this comment.
I use it for the finally.
Member
There was a problem hiding this comment.
The finally isn't needed then right? If it will not throw anyway?
Member
Author
There was a problem hiding this comment.
if an error happens in the inner try, we do a return.
So now in both error case + when finished will we set uploading to 0 and refresh.
balloob
force-pushed
the
allow-upload-multiple
branch
from
fc192d9 to
e0e6ac5
Compare
zsarnett
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
CleanShot.2022-02-14.at.10.22.34.mp4
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: