Skip to content

Allow adding Zigbee/Zwave device#11650

Merged
bramkragten merged 6 commits intodevfrom
add-zjs-zwave-add-integration
Feb 11, 2022
Merged

Allow adding Zigbee/Zwave device#11650
bramkragten merged 6 commits intodevfrom
add-zjs-zwave-add-integration

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 10, 2022

Breaking change

Proposed change

Fixes look of search-input in the add integration handler after migration to mwc.

If ZJS/ZHA configured, add option to add devices.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:


private _renderRow(handler: HandlerObj) {
return html`
<paper-icon-item @click=${this._handlerPicked} .handler=${handler}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just move this on over to MWC while we are here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bramkragten bramkragten merged commit ee1fd3e into dev Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-zjs-zwave-add-integration branch February 11, 2022 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants