Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/data-table/ha-data-table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ export class HaDataTable extends LitElement {
}
}

private _handleRowCheckboxClick(ev: Event) {
private _handleRowCheckboxClick = (ev: Event) => {
const checkbox = ev.currentTarget as HaCheckbox;
const rowId = (checkbox as any).rowId;

Expand All @@ -539,16 +539,16 @@ export class HaDataTable extends LitElement {
this._checkedRows = this._checkedRows.filter((row) => row !== rowId);
}
this._checkedRowsChanged();
}
};

private _handleRowClick(ev: Event) {
private _handleRowClick = (ev: Event) => {
const target = ev.target as HTMLElement;
if (["HA-CHECKBOX", "MWC-BUTTON"].includes(target.tagName)) {
return;
}
const rowId = (ev.currentTarget as any).rowId;
fireEvent(this, "row-click", { id: rowId }, { bubbles: false });
}
};

private _checkedRowsChanged() {
// force scroller to update, change it's items
Expand Down
52 changes: 32 additions & 20 deletions src/dialogs/quick-bar/ha-quick-bar.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import "@lit-labs/virtualizer";
import "@material/mwc-list/mwc-list";
import type { List } from "@material/mwc-list/mwc-list";
import { SingleSelectedEvent } from "@material/mwc-list/mwc-list-foundation";
import "@material/mwc-list/mwc-list-item";
import type { ListItem } from "@material/mwc-list/mwc-list-item";
import {
Expand Down Expand Up @@ -124,18 +122,28 @@ export class QuickBar extends LitElement {
fireEvent(this, "dialog-closed", { dialog: this.localName });
}

private _getItems = memoizeOne(
(commandMode: boolean, commandItems, entityItems, filter: string) => {
const items = commandMode ? commandItems : entityItems;

if (items && filter && filter !== " ") {
return this._filterItems(items, filter);
}
return items;
}
);

protected render() {
if (!this._opened) {
return html``;
}

let items: QuickBarItem[] | undefined = this._commandMode
? this._commandItems
: this._entityItems;

if (items && this._filter && this._filter !== " ") {
items = this._filterItems(items, this._filter);
}
const items: QuickBarItem[] | undefined = this._getItems(
this._commandMode,
this._commandItems,
this._entityItems,
this._filter
);

return html`
<ha-dialog
Expand Down Expand Up @@ -210,11 +218,12 @@ export class QuickBar extends LitElement {
</div>
`
: html`
<mwc-list @selected=${this._handleSelected}>
<mwc-list>
<lit-virtualizer
scroller
@keydown=${this._handleListItemKeyDown}
@rangechange=${this._handleRangeChanged}
@click=${this._handleItemClick}
class="ha-scrollbar"
style=${styleMap({
height: this._narrow
Expand Down Expand Up @@ -336,16 +345,6 @@ export class QuickBar extends LitElement {
this.closeDialog();
}

private _handleSelected(ev: SingleSelectedEvent) {
const index = ev.detail.index;
if (index < 0) {
return;
}

const item = ((ev.target as List).items[index] as any).item;
this.processItemAndCloseDialog(item, index);
}

private _handleInputKeyDown(ev: KeyboardEvent) {
if (ev.code === "Enter") {
const firstItem = this._getItemAtIndex(0);
Expand Down Expand Up @@ -443,12 +442,25 @@ export class QuickBar extends LitElement {
this._getItemAtIndex(Number(index) - 1)?.focus();
}
}
if (ev.key === "Enter" || ev.key === " ") {
this.processItemAndCloseDialog(
(ev.target as any).item,
Number((ev.target as HTMLElement).getAttribute("index"))
);
}
if (ev.key === "Backspace" || isSingleCharacter) {
(ev.currentTarget as HTMLElement).scrollTop = 0;
this._filterInputField?.focus();
}
}

private _handleItemClick(ev) {
this.processItemAndCloseDialog(
(ev.target as any).item,
Number((ev.target as HTMLElement).getAttribute("index"))
);
}

private _generateEntityItems(): EntityItem[] {
return Object.keys(this.hass.states)
.map((entityId) => {
Expand Down