Skip to content

Create error when trying to backup wile system in freeze#11634

Merged
ludeeus merged 2 commits intodevfrom
Create-error-when-trying-to-backup-wile-system-in-freeze
Feb 10, 2022
Merged

Create error when trying to backup wile system in freeze#11634
ludeeus merged 2 commits intodevfrom
Create-error-when-trying-to-backup-wile-system-in-freeze

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Feb 10, 2022

Breaking change

Proposed change

Before the "update" button was "disabled" without any reason. As I have been told, conditionally disabling buttons is not good, so this PR removes that logic and makes the button always clickable, but now adds an error if backup/restore is already running.
Unchecking the create backup box will still allow you to update just like before.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Feb 10, 2022
bramkragten
bramkragten previously approved these changes Feb 10, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@ludeeus ludeeus merged commit 92a9ed7 into dev Feb 10, 2022
@ludeeus ludeeus deleted the Create-error-when-trying-to-backup-wile-system-in-freeze branch February 10, 2022 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants