Create error when trying to backup wile system in freeze#11634
Merged
Conversation
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
previously approved these changes
Feb 10, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Before the "update" button was "disabled" without any reason. As I have been told, conditionally disabling buttons is not good, so this PR removes that logic and makes the button always clickable, but now adds an error if backup/restore is already running.
Unchecking the create backup box will still allow you to update just like before.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: