Conversation
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
bramkragten
reviewed
Feb 10, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-state.ts
Show resolved
Hide resolved
bramkragten
reviewed
Feb 10, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-state.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 10, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-state.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 10, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-state.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Feb 10, 2022
|
|
||
| @property({ type: Boolean }) public disabled = false; | ||
|
|
||
| @property() public schema?: HaFormSchema; |
Member
There was a problem hiding this comment.
We should not pass the ha-form schema to the selector, just the elements we need.
So we should just set required here.
Member
There was a problem hiding this comment.
And this changes the functionality now for other uses, they would be required by default, but now they are optional by default?
Contributor
Author
There was a problem hiding this comment.
Gotcha. Schema was already being passed so I just picked it up
Member
There was a problem hiding this comment.
Yeah, but a selector should be usable without ha-form
bramkragten
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Converts the State Trigger form to ha-form
Adds Duration Selector
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: