Skip to content

Only load ha-selector when needed#11630

Merged
zsarnett merged 1 commit intodevfrom
dynamicly-load-selectors
Feb 9, 2022
Merged

Only load ha-selector when needed#11630
zsarnett merged 1 commit intodevfrom
dynamicly-load-selectors

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

To prevent auth / onboarding from getting too big

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett merged commit 134ed7d into dev Feb 9, 2022
@zsarnett zsarnett deleted the dynamicly-load-selectors branch February 9, 2022 23:14
!selectorImported &&
changedProperties.has("schema") &&
this.schema &&
this.schema.some((item) => "selector" in item)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.schema?.some(

@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants