Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial focus for device, area, and entity dialogs #11622

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Set initial focus for device, area, and entity dialogs #11622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ac3d5d
Set initial focus for area settings dialog
steverep Feb 9, 2022
51b2c6e
Set initial focus for device settings dialog
steverep Feb 9, 2022
8b9ffbf
Set initial focus for entity settings dialog
steverep Feb 9, 2022
8ee3a23
Set initial focus for more info dialog
steverep Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dialogs/more-info/ha-more-info-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export class MoreInfoDialog extends LitElement {
.label=${this.hass.localize(
"ui.dialogs.more_info_control.details"
)}
dialogInitialFocus
></mwc-tab>
<mwc-tab
.label=${this.hass.localize(
Expand All @@ -174,7 +175,7 @@ export class MoreInfoDialog extends LitElement {
`
: ""}
</div>
<div class="content">
<div class="content" tabindex="-1" dialogInitialFocus>
${cache(
this._currTabIndex === 0
? html`
Expand Down
1 change: 1 addition & 0 deletions src/panels/config/areas/dialog-area-registry-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class DialogAreaDetail extends LitElement {
"ui.panel.config.areas.editor.name_required"
)}
.invalid=${nameInvalid}
dialogInitialFocus
></paper-input>
<ha-picture-upload
.hass=${this.hass}
Expand Down
1 change: 1 addition & 0 deletions src/panels/config/devices/device-registry-detail/dialog-device-registry-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class DialogDeviceRegistryDetail extends LitElement {
.label=${this.hass.localize("ui.panel.config.devices.name")}
.placeholder=${device.name || ""}
.disabled=${this._submitting}
dialogInitialFocus
></paper-input>
<ha-area-picker
.hass=${this.hass}
Expand Down
1 change: 1 addition & 0 deletions src/panels/config/entities/dialog-entity-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export class DialogEntityEditor extends LitElement {
.label=${this.hass.localize(
"ui.dialogs.entity_registry.settings"
)}
dialogInitialFocus
>
</mwc-tab>
${Object.entries(this._extraTabs).map(
Expand Down