Convert Automation Action Choose to HA Form#11597
Merged
Conversation
balloob
approved these changes
Feb 7, 2022
Member
|
When all forms migrated, we should make sure all ha-form related components (including selectors and this action component) are in the ha-form folder so it's easier to indicate that one should use ha-form. |
bramkragten
reviewed
Feb 8, 2022
| .actions=${option.sequence} | ||
| <ha-form | ||
| .hass=${this.hass} | ||
| .schema=${[{ name: "sequence", selector: { action: {} } }]} |
Member
There was a problem hiding this comment.
Don't create static objects in render, as they will be recreated on every render (every state change), they will not pass a strict equality check and thus will cause a re-render down the line while not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Changing automation Editors to HA Form
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: