Skip to content

Fix clearing device in device action #11594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsarnett merged 2 commits into from
Feb 7, 2022
Merged

Fix clearing device in device action #11594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71af33
Fix clearing device in device action
bramkragten Feb 7, 2022
cb2d46f
Update developer-tools-state.js
bramkragten Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/panels/config/automation/action/types/ha-automation-action-device_id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ export class HaDeviceAction extends LitElement {
private _devicePicked(ev) {
ev.stopPropagation();
this._deviceId = ev.target.value;
if (this._deviceId === undefined) {
fireEvent(this, "value-changed", {
value: HaDeviceAction.defaultConfig,
});
}
}

private _deviceActionPicked(ev) {
Expand Down
5 changes: 5 additions & 0 deletions src/panels/config/automation/condition/types/ha-automation-condition-device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ export class HaDeviceCondition extends LitElement {
private _devicePicked(ev) {
ev.stopPropagation();
this._deviceId = ev.target.value;
if (this._deviceId === undefined) {
fireEvent(this, "value-changed", {
value: { ...HaDeviceCondition.defaultConfig, condition: "device" },
});
}
}

private _deviceConditionPicked(ev) {
Expand Down
5 changes: 5 additions & 0 deletions src/panels/config/automation/trigger/types/ha-automation-trigger-device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ export class HaDeviceTrigger extends LitElement {
private _devicePicked(ev) {
ev.stopPropagation();
this._deviceId = ev.target.value;
if (this._deviceId === undefined) {
fireEvent(this, "value-changed", {
value: { ...HaDeviceTrigger.defaultConfig, platform: "device" },
});
}
}

private _deviceTriggerPicked(ev) {
Expand Down
2 changes: 1 addition & 1 deletion src/panels/developer-tools/state/developer-tools-state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ class HaPanelDevState extends EventsMixin(LocalizeMixin(PolymerElement)) {
}

entityIdChanged() {
if (this._entityId === "") {
if (!this._entityId) {
this._entity = undefined;
this._state = "";
this._stateAttributes = "";
Expand Down