Make zwave_js config panel inclusion state aware#11556
Make zwave_js config panel inclusion state aware#11556bramkragten merged 9 commits intohome-assistant:devfrom
Conversation
|
Core PR is approved and waiting for frontend team feedback. |
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
…ve_js-config-dashboard.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ve_js-config-dashboard.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts
Outdated
Show resolved
Hide resolved
|
On the Z-Wave page we use To keep it consistent the alert could be changed to |
It's not a must to use the words exclusion/inclusion. At the same time, it's not 100% accurate that the integration is searching for devices. The Z-Wave JS driver is searching for devices and it may have been initiated from HA but it may not have been. Maybe then we say |
Yeah let's do that! |
Proposed change
Related to home-assistant/core#65398
This code probably needs some work as it feels a bit hacked together, but the end result is that when a user loads the
zwave_jsconfig panel while an inclusion/exclusion is in progress, the buttons to add and remove devices disappear and an alert is shown with an option to cancel (see screenshot below). A couple of things to consider/improve:Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: