Conversation
zsarnett
reviewed
Feb 4, 2022
balloob
added
the
needs design preview
balloob
reviewed
Feb 4, 2022
| import "@polymer/paper-item/paper-item-body"; | ||
| import "@polymer/paper-listbox/paper-listbox"; | ||
| import "@vaadin/vaadin-combo-box/theme/material/vaadin-combo-box-light"; | ||
| import "@vaadin/combo-box/theme/material/vaadin-combo-box-light"; |
Member
There was a problem hiding this comment.
When no areas, the target selector looks weird when picking an area:
Member
There was a problem hiding this comment.
balloob
reviewed
Feb 4, 2022
| import "@polymer/paper-item/paper-icon-item"; | ||
| import "@polymer/paper-item/paper-item-body"; | ||
| import "@vaadin/vaadin-combo-box/theme/material/vaadin-combo-box-light"; | ||
| import "@vaadin/combo-box/theme/material/vaadin-combo-box-light"; |
Member
There was a problem hiding this comment.
In target selector when no entities (not very common use case I know)
balloob
approved these changes
Feb 4, 2022
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
A few empty combobox issues left, rest looks good 👍
Member
Author
|
I just converted the base element now, not all comboboxes use the base element yet, that is the next step and should make all comboboxes look the same and good :-) |
Member
|
Fantastic. Thanks for jumping right on this @bramkragten et al. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrates combo box to mwc
Next step, migrate all comboboxes to use
ha-comboboxType of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: