Skip to content

Add aria-label to table headers with no title#11503

Merged
bramkragten merged 16 commits intohome-assistant:devfrom
Nardol:icon-aria-label
Feb 9, 2022
Merged

Add aria-label to table headers with no title#11503
bramkragten merged 16 commits intohome-assistant:devfrom
Nardol:icon-aria-label

Conversation

@Nardol
Copy link
Copy Markdown
Contributor

@Nardol Nardol commented Feb 1, 2022

Proposed change

Some table headers, especialy in different configurations, has no visible title which produce empty cells.
Empty cells could cause somme issues for screen readers users I.E. NVDA.
Using aria-label attribute for these headers allows having content for screen readers which is invisible on screen, adding an aria-label property to ha-data-table allows to add them on config parts which have empty headers.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
@Nardol Nardol marked this pull request as ready for review February 9, 2022 18:04
@bramkragten bramkragten enabled auto-merge (squash) February 9, 2022 18:09
@bramkragten bramkragten merged commit d37d992 into home-assistant:dev Feb 9, 2022
@Nardol Nardol deleted the icon-aria-label branch February 9, 2022 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants