Add WORKSPACE_DIRECTORY environment variable to devcontainer and script.core#11477
Merged
ludeeus merged 3 commits intohome-assistant:devfrom Feb 12, 2022
Merged
Conversation
Member
|
This is a script used in our devcontainer. Joakim wrote it so let him review. I'm fine with making it more generic as long as the devcontainer continues to work 👍 |
Member
Author
|
I'm using the dev-container, but i did not clone the repo into |
ludeeus
reviewed
Jan 29, 2022
ludeeus
reviewed
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
use
PWDenv variable instead of static/workspaces/frontendwhich fails, when the repo is checked out into another folder (eg./workspaces/homeassistant-frontend)Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: