Skip to content

Weather card without chart#1117

Merged
balloob merged 17 commits intomasterfrom
weathercard
Apr 26, 2018
Merged

Weather card without chart#1117
balloob merged 17 commits intomasterfrom
weathercard

Conversation

@c727
Copy link
Copy Markdown
Contributor

@c727 c727 commented Apr 22, 2018

backend PR: home-assistant/core#14076

fix: #999
fix: #464

current:
current

PR:
unbenannt

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 22, 2018

We could also use these colored icons (with or without animation) but they are not 100% material https://www.amcharts.com/free-animated-svg-weather-icons/
icons

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Apr 22, 2018

Super excited about this 👍

Wondering if user can configure whether to use the animated icons or the static ones for the weather card.

Comment thread src/cards/ha-weather-card.html Outdated
</div>
<div class="attribute flex">
<div class="icon-container">
<iron-icon icon="mdi:flag-variant"></iron-icon>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdi:weather-windy may be a better icon for wind_speed.

Comment thread src/translations/en.json Outdated
"air_pressure": "Air pressure",
"humidity": "Humidity",
"visibility": "Visibility",
"wind_bearing": "[\"N\", \"NNE\", \"NE\", \"ENE\", \"E\", \"ESE\", \"SE\", \"SSE\", \"S\", \"SSW\", \"SW\", \"WSW\", \"W\", \"WNW\", \"NW\", \"NNW\", \"N\"]",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this OK?

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 23, 2018

The middlepart looks messy and cramped. The measurements are not aligned with icon/label. We need a better way.

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 23, 2018

what about this? suggestions are welcome
1
this

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 23, 2018

2
without text
3
without text2

btw: @arsaboo we can't change the icon set without using customize and the code for colored icons was already rejected

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Apr 23, 2018

I like no. 2.

@ghost
Copy link
Copy Markdown

ghost commented Apr 23, 2018

For me good is no. 1 and no. 2

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 23, 2018

The challenge with 3 is the lack of description. 2 is still chaotic. Every row has it's own column section. I prefer 1.

make sure btw that everything on the left is aligned. Look how the table starts further in than the icon and the icon starts further in than the header. It should all be starting at the same line.

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 23, 2018

Thinking about it more, maybe the humidity, pressure etc are not important enough to be in the card. We can move them to the more info ?

@raccettura
Copy link
Copy Markdown
Contributor

I'd say humidity is pretty important for a decent sized part of the world where heat index is a normal part of the forecast during warmer months. Pressure IMHO is not terribly important for most people.

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 23, 2018

Fair point. So let's at least scrap pressure from the main view.

@NovapaX
Copy link
Copy Markdown
Contributor

NovapaX commented Apr 23, 2018

Maybe limit the amount of forecast days shown in the card?
I'd say 5 or 7 would be enough, the rest can go in the more-info in a list-style instead of columns.

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 23, 2018

new design in first post, forecast has max. 7 days now

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Apr 23, 2018

Looks good. Can we fix the alignment of the text on the right to be closer to your post here

@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Apr 23, 2018

Also, for English, should we use the standard 3 letters for days (Mon, Tue, etc.) now that we have some space?

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 23, 2018

...this is German

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 24, 2018

please check if you agree with my changes in translation file

more-info

@fanthos
Copy link
Copy Markdown
Contributor

fanthos commented Apr 24, 2018

I like the new design mostly, but the table style does not work well with platform that has per-hour forecast, like OpenWeatherMap.
#375 #373
I think we can create a bar with weather condition, but needs more work to make it align with the chart.

@Yevgenium
Copy link
Copy Markdown
Contributor

Maybe visibility can also be hidden?

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 24, 2018

Can we focus the discussions on major issues like fanthos posted, please

@fanthos
Copy link
Copy Markdown
Contributor

fanthos commented Apr 24, 2018

I think the per-hour works better in more cases. The daily forecast convert could be done in frontend if needed.

@fanthos
Copy link
Copy Markdown
Contributor

fanthos commented Apr 24, 2018

Relative easy to replace Google Charts with Chart.js.
image
Code:
https://github.com/fanthos/home-assistant-polymer/tree/weather

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 24, 2018

IMO if you have both, temp and tempLow, a graph makes no sense
yahoo and BR have this for example

@fanthos
Copy link
Copy Markdown
Contributor

fanthos commented Apr 24, 2018

You are right.
But I think we better keep existing data, or provide feature like fallback to chart.
After some search, many API providers has free hourly forecast for developers.
https://www.wunderground.com/weather/api/d/pricing.html

@c727
Copy link
Copy Markdown
Contributor Author

c727 commented Apr 24, 2018

finished :)

final

@balloob balloob merged commit a983a5d into master Apr 26, 2018
@balloob balloob deleted the weathercard branch April 26, 2018 21:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants