-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various supervisor tooltip and aria-label issues #10878
Merged
spacegaier
merged 5 commits into
home-assistant:dev
from
spacegaier:issue-3267-supervisor-dialogs
Jan 25, 2022
Merged
Fix various supervisor tooltip and aria-label issues #10878
spacegaier
merged 5 commits into
home-assistant:dev
from
spacegaier:issue-3267-supervisor-dialogs
Jan 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
requested changes
Jan 11, 2022
@ludeeus Ready for final review from my side. |
ludeeus
reviewed
Jan 25, 2022
ludeeus
reviewed
Jan 25, 2022
ludeeus
approved these changes
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Various translation attempted to use
this.hass
but that does not work for supervisor specific translations. Aligned the occurrences that I found.Note: I don't have a supervisor dev instance => untested.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: