Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various supervisor tooltip and aria-label issues #10878

Merged

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Various translation attempted to use this.hass but that does not work for supervisor specific translations. Aligned the occurrences that I found.

Note: I don't have a supervisor dev instance => untested.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion: Unlabeled buttons #3267
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added the Supervisor Related to the supervisor panel label Dec 12, 2021
@zsarnett zsarnett requested review from ludeeus and removed request for ludeeus January 11, 2022 15:26
@zsarnett zsarnett requested a review from ludeeus January 25, 2022 14:46
@spacegaier spacegaier marked this pull request as draft January 25, 2022 16:03
@spacegaier spacegaier marked this pull request as ready for review January 25, 2022 16:16
@spacegaier
Copy link
Member Author

@ludeeus Ready for final review from my side.

src/translations/en.json Outdated Show resolved Hide resolved
@spacegaier spacegaier enabled auto-merge (squash) January 25, 2022 16:28
@spacegaier spacegaier merged commit ffaff30 into home-assistant:dev Jan 25, 2022
@spacegaier spacegaier deleted the issue-3267-supervisor-dialogs branch January 25, 2022 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants