Use unit system definitions for weather units#10657
Merged
bramkragten merged 6 commits intohome-assistant:devfrom Dec 2, 2021
Merged
Use unit system definitions for weather units#10657bramkragten merged 6 commits intohome-assistant:devfrom
bramkragten merged 6 commits intohome-assistant:devfrom
Conversation
Member
|
HAWS 5.11.3 released with your type update https://github.com/home-assistant/home-assistant-js-websocket/releases/tag/5.11.3 |
bramkragten
reviewed
Nov 29, 2021
Comment on lines
156
to
+162
| case "pressure": | ||
| return lengthUnit === "km" ? "hPa" : "inHg"; | ||
| return hass.config.unit_system.pressure || ""; | ||
| case "wind_speed": | ||
| return `${lengthUnit}/h`; | ||
| return hass.config.unit_system.wind_speed || ""; | ||
| case "visibility": | ||
| case "length": | ||
| return lengthUnit; | ||
| return hass.config.unit_system.length || ""; |
Member
There was a problem hiding this comment.
Remove the case for pressure, wind_speed, and length as they can be handled by the default now.
bramkragten
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Integrations that report their wind speed in km/h under the metric system will now display the wrong unit (the backend reports them as m/s). It might be worth waiting until the backend work of fixing unit conversion in the integrations is finished to merge this.
Proposed change
Now that wind speed and accumulated precipitation units have been added to the unit system, there is no longer any need to hard-code these in the frontend. These units are now taken directly from the unit system.
Also I made a PR in the websocket repo to add the types necessary for this: home-assistant/home-assistant-js-websocket#215.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: