Inconsistent and unnecessary "Close selection mode" key

[NoRi2909]

Describe the issue you are experiencing

There are two ways to exit selection mode in Settings:

• Select "Close selection mode" from the Select menu
• Click the X in the upper left

However, when you hover over the X icon the overlay says "Exit selection mode"

Describe the behavior you expected

Both should be made consistent by using the same key for both elements in the UI.
This simplifies translations quite a bit, too.

There should be

frontend/src/translations/en.json

Line 532 in a04a449

"exit_selection_mode": "Exit selection mode",

used in both places and the following can be removed:

frontend/src/translations/en.json

Line 541 in a04a449

"close_select_mode": "Close selection mode",

This also makes it consistent with all other "exit mode" keys like, e.g.:

frontend/src/translations/en.json

Line 1178 in a04a449

"exit_edit_mode": "Exit edit mode",

Steps to reproduce the issue

1. Go to any list view in Settings
2. Enable selection mode using the button next to the Filter button.
3. Compare the menu item and the overlay for the X.

What version of Home Assistant Core has the issue?

core-2024.10.2

[NoRi2909]

@j4n-e4t That's one for you. Note that here the fix is not just removing close_select_mode from the strings file, but also in the actual code replacing close_select_mode with exit_selection_mode.
I did not find that code myself, but you know your way around in github much better than me. 😃

[j4n-e4t]

I've now replaced all occurrences of close_select_mode with exit_selection_mode. Could you take a look? (#22434)

[NoRi2909]

Looks OK to me. Let's see if it goes through. Then we have a consistent UI in that area.