Skip to content

Add MultiFactorAuthModule.async_initialize_login_mfa_step#80

Merged
balloob merged 4 commits intomasterfrom
awarecan-patch-1
Sep 12, 2018
Merged

Add MultiFactorAuthModule.async_initialize_login_mfa_step#80
balloob merged 4 commits intomasterfrom
awarecan-patch-1

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

@awarecan awarecan commented Sep 1, 2018

home-assistant/core#16314

Add MultiFactorAuthModule.async_initialize_login_mfa_step
Change async_validation => async_validate

Comment thread docs/auth_auth_module.md Outdated
| `async def async_is_user_setup(self, user_id)` | Yes | Return whether user is set up.
| `async def async_validate(self, user_id, user_input)` | Yes | Given a user_id and user input, return valiidation result.
| `async def async_generate(self, user_id)` | No | Generate a init code, if return result, the result will be shown as `description_placeholders['mfa_init_code']` in login flow's `mfa` step.
| `async def async_generate(self, user_id)` | No | Generate a init code. Be called once before display the mfa step of login flow.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is no longer being added?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You was reviewing on an outdated commit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@awarecan awarecan changed the title Add MultiFactorAuthModule.async_generate Add MultiFactorAuthModule.async_initialize_login_mfa_step Sep 10, 2018
@balloob balloob merged commit 512da68 into master Sep 12, 2018
@balloob balloob deleted the awarecan-patch-1 branch September 12, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants