Add support for odhcpd DHCP server#9858
Merged
Conversation
This commit adds support for the odhcp DHCP server in addition to dnsmasq. A new configuration option 'dhcp_software' has been added and allows the user to set the server used (defaults to dnsmasq to not break existing installations).
Contributor
|
Hi @chemicalstorm, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Author
|
I have been running this code for 2 weeks or so using odhcp. I would be glad to have reviews from people using dnsmasq to ensure I didn't break anything when refactoring the code. Note: I haven't been able to run tox because I kept running in some issues (#7108), so I hope that travis will be able to find if there are any problem left with the code! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for the odhcp DHCP server in addition to dnsmasq. A new configuration option 'dhcp_software' has been added and allows the user to set the server used (defaults to dnsmasq to not break existing installations).
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3631
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass