Skip to content

Add support for odhcpd DHCP server#9858

Merged
fabaff merged 1 commit into
devfrom
unknown repository
Oct 31, 2017
Merged

Add support for odhcpd DHCP server#9858
fabaff merged 1 commit into
devfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 14, 2017

Description:

This PR adds support for the odhcp DHCP server in addition to dnsmasq. A new configuration option 'dhcp_software' has been added and allows the user to set the server used (defaults to dnsmasq to not break existing installations).

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3631

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: ubus
    host: gaia.example.org
    username: hass
    password: 1234
    dhcp_software: dnsmasq

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

This commit adds support for the odhcp DHCP server in addition to
dnsmasq. A new configuration option 'dhcp_software' has been added and
allows the user to set the server used (defaults to dnsmasq to not break
existing installations).
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @chemicalstorm,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 14, 2017

I have been running this code for 2 weeks or so using odhcp. I would be glad to have reviews from people using dnsmasq to ensure I didn't break anything when refactoring the code.

Note: I haven't been able to run tox because I kept running in some issues (#7108), so I hope that travis will be able to find if there are any problem left with the code!

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 6b96bc3 into home-assistant:dev Oct 31, 2017
@balloob balloob mentioned this pull request Nov 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants