Skip to content

Make default theme selectable for set theme service#96849

Merged
frenck merged 1 commit into
devfrom
set_theme_include_default
Jul 18, 2023
Merged

Make default theme selectable for set theme service#96849
frenck merged 1 commit into
devfrom
set_theme_include_default

Conversation

@piitaya
Copy link
Copy Markdown
Member

@piitaya piitaya commented Jul 18, 2023

Proposed change

Make default theme (Home Assistant theme) selectable from the UI. It was already possible in YAML. Even the example was default 😅

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration (frontend) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of frontend can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign frontend Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@piitaya piitaya changed the title Make default selectable for set theme service Make default theme selectable for set theme service Jul 18, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piitaya 👍

../Frenck

@frenck frenck merged commit d8c989f into dev Jul 18, 2023
@frenck frenck deleted the set_theme_include_default branch July 18, 2023 15:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants