Skip to content

Use device class naming in Renault #96038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epenet merged 1 commit into from
Jul 7, 2023
Merged

Use device class naming in Renault #96038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions homeassistant/components/renault/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,13 @@ def icon(self) -> str | None:
device_class=BinarySensorDeviceClass.PLUG,
on_key="plugStatus",
on_value=PlugState.PLUGGED.value,
translation_key="plugged_in",
),
RenaultBinarySensorEntityDescription(
key="charging",
coordinator="battery",
device_class=BinarySensorDeviceClass.BATTERY_CHARGING,
on_key="chargingStatus",
on_value=ChargeState.CHARGE_IN_PROGRESS.value,
translation_key="charging",
),
RenaultBinarySensorEntityDescription(
key="hvac_status",
Expand All @@ -112,7 +110,6 @@ def icon(self) -> str | None:
device_class=BinarySensorDeviceClass.LOCK,
on_key="lockStatus",
on_value="unlocked",
translation_key="lock_status",
),
RenaultBinarySensorEntityDescription(
key="hatch_status",
Expand Down
1 change: 0 additions & 1 deletion homeassistant/components/renault/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ def _get_utc_value(entity: RenaultSensor[T]) -> datetime:
entity_class=RenaultSensor[KamereonVehicleBatteryStatusData],
native_unit_of_measurement=PERCENTAGE,
state_class=SensorStateClass.MEASUREMENT,
translation_key="battery_level",
),
RenaultSensorEntityDescription(
key="charge_state",
Expand Down
12 changes: 0 additions & 12 deletions homeassistant/components/renault/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@
},
"entity": {
"binary_sensor": {
"charging": {
"name": "[%key:component::binary_sensor::entity_component::battery_charging::name%]"
},
"hatch_status": {
"name": "Hatch"
},
Expand All @@ -46,15 +43,9 @@
"hvac_status": {
"name": "HVAC"
},
"lock_status": {
"name": "[%key:component::binary_sensor::entity_component::lock::name%]"
},
"passenger_door_status": {
"name": "Passenger door"
},
"plugged_in": {
"name": "[%key:component::binary_sensor::entity_component::plug::name%]"
},
"rear_left_door_status": {
"name": "Rear left door"
},
Expand Down Expand Up @@ -101,9 +92,6 @@
"battery_last_activity": {
"name": "Last battery activity"
},
"battery_level": {
"name": "Battery level"
},
"battery_temperature": {
"name": "Battery temperature"
},
Expand Down
6 changes: 3 additions & 3 deletions tests/components/renault/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
},
{
ATTR_DEVICE_CLASS: SensorDeviceClass.BATTERY,
ATTR_ENTITY_ID: "sensor.reg_number_battery_level",
ATTR_ENTITY_ID: "sensor.reg_number_battery",
ATTR_STATE: "60",
ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT,
ATTR_UNIQUE_ID: "vf1aaaaa555777999_battery_level",
Expand Down Expand Up @@ -386,7 +386,7 @@
},
{
ATTR_DEVICE_CLASS: SensorDeviceClass.BATTERY,
ATTR_ENTITY_ID: "sensor.reg_number_battery_level",
ATTR_ENTITY_ID: "sensor.reg_number_battery",
ATTR_STATE: "50",
ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT,
ATTR_UNIQUE_ID: "vf1aaaaa555777999_battery_level",
Expand Down Expand Up @@ -621,7 +621,7 @@
},
{
ATTR_DEVICE_CLASS: SensorDeviceClass.BATTERY,
ATTR_ENTITY_ID: "sensor.reg_number_battery_level",
ATTR_ENTITY_ID: "sensor.reg_number_battery",
ATTR_STATE: "60",
ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT,
ATTR_UNIQUE_ID: "vf1aaaaa555777123_battery_level",
Expand Down
36 changes: 18 additions & 18 deletions tests/components/renault/snapshots/test_binary_sensor.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_lock_status',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -325,7 +325,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -353,7 +353,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -381,7 +381,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_lock_status',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -674,7 +674,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -702,7 +702,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -828,7 +828,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -856,7 +856,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -912,7 +912,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_lock_status',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1216,7 +1216,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_lock_status',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1487,7 +1487,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1515,7 +1515,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1543,7 +1543,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777123_lock_status',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1836,7 +1836,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1864,7 +1864,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -1990,7 +1990,7 @@
'original_name': 'Plug',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'plugged_in',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_plugged_in',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -2018,7 +2018,7 @@
'original_name': 'Charging',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'charging',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_charging',
'unit_of_measurement': None,
}),
Expand Down Expand Up @@ -2074,7 +2074,7 @@
'original_name': 'Lock',
'platform': 'renault',
'supported_features': 0,
'translation_key': 'lock_status',
'translation_key': None,
'unique_id': 'vf1aaaaa555777999_lock_status',
'unit_of_measurement': None,
}),
Expand Down
Loading