Skip to content

Create zwave_js repair issue instead of warning log entry#95997

Merged
frenck merged 27 commits into
home-assistant:devfrom
adrianmo:zwavejs_dry_fan_preset_repair
Jul 25, 2023
Merged

Create zwave_js repair issue instead of warning log entry#95997
frenck merged 27 commits into
home-assistant:devfrom
adrianmo:zwavejs_dry_fan_preset_repair

Conversation

@adrianmo
Copy link
Copy Markdown
Contributor

@adrianmo adrianmo commented Jul 6, 2023 •
edited
Loading

Proposed change

This PR addresses comment by @MartinHjelmare in #95634 (comment). Besides logging a warning, this will also create a repair issue when somebody tries to set either the Fan or Dry preset mode in their Z-Wave climate entities. It will create a separate repair issue for the different climate entities affected.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@adrianmo
Create repair issue instead of warning log
56b3471 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo requested a review from a team as a code owner July 6, 2023 13:53
@home-assistant home-assistant Bot added cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: zwave_js small-pr PRs with less than 30 lines. Quality Scale: platinum labels Jul 6, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

adrianmo added 2 commits July 6, 2023 13:57
@adrianmo
Use the same issue id for both dry and fan presets
14f5161 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
Remove THERMOSTAT_MODE_SETPOINT_MAP (revert change)
14dfb7a 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo mentioned this pull request Jul 6, 2023
Merged
20 tasks
raman325
raman325 reviewed Jul 6, 2023
View reviewed changes
Comment thread homeassistant/components/zwave_js/strings.json Outdated
adrianmo added 3 commits July 6, 2023 14:15
@adrianmo
Update repair text
364a459 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'dev' into zwavejs_dry_fan_preset_repair
1cf51f7
@adrianmo
Make repair issue fixable
bc9383d 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
Copy link
Copy Markdown
Contributor Author

adrianmo commented Jul 6, 2023

@MartinHjelmare can you please review this PR when you get a chance to make sure it's aligned to what you suggested in the previous PR? Thanks!

@adrianmo
Fix plural
e7d6ea5 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo changed the title Create repair issue instead of warning log Create repair issue instead of warning log entry Jul 6, 2023
jbouwh
jbouwh previously requested changes Jul 6, 2023
View reviewed changes
Comment thread homeassistant/components/zwave_js/climate.py
Comment thread homeassistant/components/zwave_js/climate.py
Comment thread homeassistant/components/zwave_js/climate.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft July 6, 2023 21:07
@MartinHjelmare MartinHjelmare changed the title Create repair issue instead of warning log entry Create zwave_js repair issue instead of warning log entry Jul 7, 2023
MartinHjelmare
MartinHjelmare reviewed Jul 7, 2023
View reviewed changes
Comment thread tests/components/zwave_js/test_climate.py Outdated
Comment thread tests/components/zwave_js/test_climate.py Outdated
adrianmo and others added 5 commits July 7, 2023 09:36
@adrianmo @MartinHjelmare
Update tests/components/zwave_js/test_climate.py
f60420b 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@adrianmo @MartinHjelmare
Update tests/components/zwave_js/test_climate.py
a37a2ec 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@adrianmo
Add warning log back again
7da0baf 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
revert unrelated change
edf5d66 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
update test case comment
1b83913 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo marked this pull request as ready for review July 7, 2023 08:06
@adrianmo
Copy link
Copy Markdown
Contributor Author

adrianmo commented Jul 7, 2023

6 months sounds right to me. So 2023.8 for deprecation, 2024.2 for removal. If we miss the date it's fine but we are guaranteeing it won't be deprecated before then

Makes sense. I've added breaks_in_ha_version="2024.2.0" to the repair issue.

@raman325
Copy link
Copy Markdown
Contributor

raman325 commented Jul 7, 2023

@MartinHjelmare do we need the version that introduced the deprecation (2023.8) in the warning/issue? We currently don't mention it. I personally think it's OK not to include, but I would add the final date to the warning (2024.2) @adrianmo

@adrianmo
Copy link
Copy Markdown
Contributor Author

adrianmo commented Jul 7, 2023

@MartinHjelmare do we need the version that introduced the deprecation (2023.8) in the warning/issue? We currently don't mention it. I personally think it's OK not to include, but I would add the final date to the warning (2024.2) @adrianmo

@raman325 - agreed. I've just added the breaking change date to the warning and repair issue.

raman325
raman325 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will wait for @MartinHjelmare to way in on the deprecation date comment before merging

thanks for your patience @adrianmo !

MartinHjelmare
MartinHjelmare reviewed Jul 8, 2023
View reviewed changes
Comment thread homeassistant/components/zwave_js/strings.json Outdated
@frenck frenck marked this pull request as draft July 8, 2023 10:50
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 8, 2023

Converted this PR to draft to get the last comment addressed.

adrianmo added 2 commits July 10, 2023 15:37
@adrianmo
remove hardcoded HA version from strings.json
d5a69db 
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'zwavejs_dry_fan_preset_repair' of github.com:adrianmo/h…
c6826a8 
…omeassistant-core into zwavejs_dry_fan_preset_repair
@adrianmo adrianmo marked this pull request as ready for review July 10, 2023 15:38
@adrianmo
Copy link
Copy Markdown
Contributor Author

adrianmo commented Jul 10, 2023

Marking the PR as 'ready for review' to get some attention to the last open comment. /cc @MartinHjelmare @frenck

frenck
frenck reviewed Jul 11, 2023
View reviewed changes
Comment thread homeassistant/components/zwave_js/climate.py Outdated
@adrianmo

This comment was marked as spam.

Sign in to view
@adrianmo

This comment was marked as spam.

Sign in to view
@adrianmo

This comment was marked as spam.

Sign in to view
frenck
frenck approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @adrianmo 👍

PS: Please avoid the pinging next time... 😉

../Frenck

@frenck frenck merged commit f272652 into home-assistant:dev Jul 25, 2023
@adrianmo adrianmo deleted the zwavejs_dry_fan_preset_repair branch July 25, 2023 09:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@frenck frenck frenck approved these changes

@jbouwh jbouwh jbouwh approved these changes

@raman325 raman325 raman325 approved these changes

Assignees

No one assigned

Labels

cla-signed code-owner-approved deprecation Indicates a breaking change to happen in the future has-tests integration: zwave_js Quality Scale: platinum small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrianmo @MartinHjelmare @raman325 @frenck @jbouwh